ref(releasehealth): Implement get_project_sessions_count on metrics backend [INGEST-249] #29148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Oct 7, 2021
jjbayer
approved these changes
Oct 7, 2021
src/sentry/release_health/metrics.py
Outdated
|
|
||
| query = Query( | ||
| dataset=Dataset.Metrics.value, | ||
| match=Entity("metrics_counters"), |
There was a problem hiding this comment.
nit: I think we have the EntityKey enum for this now, we might as well use it.
| @@ -90,6 +91,21 @@ def filter_releases_by_project_release( | |||
| ) | |||
|
|
|||
|
|
|||
| def _model_environment_ids_to_environment_names( | |||
There was a problem hiding this comment.
nit: Will this function be used anywhere else? If not, I wonder if we could simplify to
def _get_environment_name(environment_id: int) -> Optional[str]:
try:
return Environment.objects.get(id=environment_id).name or None
except Environment.DoesNotExist:
return NoneThere was a problem hiding this comment.
Yes, I thought about just getting one environment and then changed my mind... maybe will inline when we are done.
src/sentry/release_health/metrics.py
Outdated
| @@ -90,6 +91,21 @@ def filter_releases_by_project_release( | |||
| ) | |||
|
|
|||
|
|
|||
| def _model_environment_ids_to_environment_names( | |||
| metric_ids: Sequence[int], | |||
There was a problem hiding this comment.
Should we call this environment_ids instead of metric_ids?
iProgramStuff
approved these changes
Oct 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in #28598, port get_project_sessions_count from sentry.snuba.sessions to metrics.
INGEST-249