Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ref(js): Properly type hooks in HookStore (#29141)" #29147

Conversation

evanpurkhiser
Copy link
Member

This reverts commit 3a186e0.

This appears to have negatively regressed memory usage in the typescript checker

@evanpurkhiser evanpurkhiser requested a review from a team October 7, 2021 07:38
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) October 7, 2021 07:40
@evanpurkhiser evanpurkhiser merged commit 41cccd5 into master Oct 7, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/revert-ref-js-properly-type-hooks-in-hookstore-29141- branch October 7, 2021 07:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants