Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ts): Adjust how Modal{Options,RenderProps} are imported #29144

Merged
merged 1 commit into from
Oct 7, 2021
Merged

ref(ts): Adjust how Modal{Options,RenderProps} are imported #29144

merged 1 commit into from
Oct 7, 2021

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Oct 7, 2021 •
edited
Loading

This is helpful for when we change the prop types on the GlobalModal when we refactor away the container

See #29135

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner October 7, 2021 07:27
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team October 7, 2021 07:27
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) October 7, 2021 07:49
@evanpurkhiser evanpurkhiser merged commit f6f3e8f into master Oct 7, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-ts-adjust-how-modal-options-renderprops-are-imported branch October 7, 2021 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matejminar matejminar matejminar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @matejminar