fix(ui): Fix incomplete list of member's teams #29134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| onAddTeam={this.handleAddTeam} | ||
| onRemoveTeam={this.handleRemoveTeam} | ||
| /> | ||
| <Teams slugs={member.teams}> |
evanpurkhiser
approved these changes
Oct 7, 2021
Had a look at the tests and it seems like everything is fine. I could make a test to ensure that it fetches members teams if they aren't part of the store already, but I feel like that is just testing the |
|
nah, lets go |
b32a45c to
2f4c522
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Due to switching settings from heavyweight org -> lightweight org, we no longer have access to all teams within the
organizationMemberDetails.tsxview. Shown in the above example as the first screenshot does not include the 200th team (team_199)In order to fetch a user's teams we must load them on the fly if they do not exist using the
Teamsutility. This also means we have to introduce a loading state for theTeamSelectcomponent.Note: The gif has an artificially long loading state of 2 seconds. Typically the user will not see the loading state for nearly this long