Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(js): Move components to the end of ToastIndicators file #29122

Merged
merged 1 commit into from
Oct 6, 2021
Merged

style(js): Move components to the end of ToastIndicators file #29122

merged 1 commit into from
Oct 6, 2021

Conversation

evanpurkhiser
Copy link
Member

We usually put the exported component first in the file.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner October 6, 2021 21:31
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team October 6, 2021 21:31
dashed
dashed approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 🔺 🟥 . approved.

@evanpurkhiser evanpurkhiser merged commit 5484fa7 into master Oct 6, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/style-js-move-components-to-the-end-of-toastindicators-file branch October 6, 2021 22:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dashed dashed dashed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @dashed