Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart-unfurls): Fix unfurls with top events #29119

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

shruthilayaj
Copy link
Member

Chart unfurls are currently broken when top
events when they are passed in with events
with non-top event display types.

Chart unfurls are currently broken when top
events when they are passed in with events
with non-top event display types.
@shruthilayaj shruthilayaj marked this pull request as ready for review October 6, 2021 20:25
@shruthilayaj shruthilayaj requested review from a team and removed request for a team October 6, 2021 20:25
Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 tyty

@shruthilayaj shruthilayaj merged commit 394cc10 into master Oct 7, 2021
@shruthilayaj shruthilayaj deleted the fix/handle-top-events-in-discover-urls branch October 7, 2021 12:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants