Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Update localstorage when project is deleted #29104

Merged
merged 4 commits into from
Oct 12, 2021
Merged

fix(ui): Update localstorage when project is deleted #29104

merged 4 commits into from
Oct 12, 2021

Conversation

mikellykels
Copy link
Contributor

Update localStorage when a project is deleted. Previously, the project ID would still be in localStorage causing a 403 from several endpoints on the issue list page.

FIXES WOR-1384

@mikellykels
fix(ui): Update localstorage when project is deleted
b4c86eb 
Update localStorage when a project is deleted. Previously, the project ID would still be in localStorage causing a 403 from several endpoints on the issue list page.

FIXES WOR-1384
@mikellykels mikellykels requested a review from a team October 6, 2021 08:08
@mikellykels mikellykels requested a review from a team as a code owner October 6, 2021 10:38
@mikellykels mikellykels requested a review from a team October 6, 2021 10:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021 •
edited
Loading

size-limit report

Path Base Size (d820b1a) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.67 KB 52.68 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

JoshFerge
JoshFerge reviewed Oct 6, 2021
View reviewed changes
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could it be worth adding an assertion for this here?

sentry/tests/js/spec/views/settings/projectGeneralSettings.spec.jsx

Line 116 in 248d3af

it('project admins can remove project', async function () {

@mikellykels mikellykels merged commit c5ee03b into master Oct 12, 2021
@mikellykels mikellykels deleted the kelly/403-project-deletion branch October 12, 2021 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

@evanpurkhiser evanpurkhiser Awaiting requested review from evanpurkhiser

@JoshFerge JoshFerge Awaiting requested review from JoshFerge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikellykels @scttcper @evanpurkhiser @JoshFerge