Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(team-insights): Add Number of Releases section #29101

Merged
merged 7 commits into from
Oct 14, 2021
Merged

feat(team-insights): Add Number of Releases section #29101

merged 7 commits into from
Oct 14, 2021

Conversation

mikellykels
Copy link
Contributor

@mikellykels mikellykels commented Oct 6, 2021 •
edited
Loading

Add Number of Releases section to Team Insights.

FIXES WOR-1394
FIXES WOR-1413

Screen Shot 2021-10-13 at 10 57 11 PM

@mikellykels
feat(team-insights): Add Number of Releases section
f138470 
Add Number of Releases section. This is only the table - the chart will be added in a follow-up PR.

FIXES WOR-1394
@mikellykels
update test
f2ca4e7
@mikellykels mikellykels requested review from scttcper and a team October 6, 2021 03:49
scttcper
scttcper previously approved these changes Oct 6, 2021
View reviewed changes
@scttcper
Copy link
Member

scttcper commented Oct 6, 2021

looks great!

@scttcper scttcper dismissed their stale review October 6, 2021 20:39

api maxes out at 100 releases

matejminar
matejminar reviewed Oct 7, 2021
View reviewed changes
Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use perPage param to get more releases than 100. Although I think the backend's hard limit is 1000.

@mikellykels mikellykels merged commit 696fe11 into master Oct 14, 2021
@mikellykels mikellykels deleted the kelly/team-insights-number-releases branch October 14, 2021 23:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iProgramStuff iProgramStuff iProgramStuff left review comments

@scttcper scttcper scttcper approved these changes

@matejminar matejminar Awaiting requested review from matejminar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikellykels @scttcper @iProgramStuff @matejminar