feat(discover-snql): Use the snql query builder for events-meta #29096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This adds a feature flag so we can try the new query builder for the events-meta endpoint - This also adds a function_alias_map so we can correctly convert the meta results on the discover endpoints
wmak
commented
Oct 6, 2021
| @@ -2261,6 +2262,7 @@ def __init__( | |||
| ), | |||
| SnQLFunction( | |||
| "count", | |||
| optional_args=[NullColumn("column")], | |||
There was a problem hiding this comment.
support older syntax of count(id) that's still floating about
Zylphrex
approved these changes
Oct 6, 2021
Comment on lines
+183
to
+186
| class OrganizationEventsMetaEndpointWithSnql(OrganizationEventsMetaEndpoint): | ||
| def setUp(self): | ||
| super().setUp() | ||
| self.features["organizations:discover-use-snql"] = True |
There was a problem hiding this comment.
Oh dang, does this actually work? 🔥
There was a problem hiding this comment.
hell yeah, gonna use this pattern for the other test cases as we convert
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
events-meta endpoint
meta results on the discover endpoints