Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): Add team issues and time to resolution #29095

Merged
merged 8 commits into from
Oct 6, 2021

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Oct 5, 2021

Adds two new team insights widgets.

Screen Shot 2021-10-05 at 4 36 14 PM

Screen Shot 2021-10-05 at 1 06 19 PM

@scttcper scttcper requested a review from a team October 5, 2021 23:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

size-limit report

Path Base Size (ad8e301) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.66 KB 52.66 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

@@ -10,6 +9,8 @@ import {t} from 'app/locale';
import space from 'app/styles/space';
import {Organization} from 'app/types';

import {convertDaySeriesToWeeks} from './utils';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Comment on lines 32 to 37
function convertKeyValueToSeries(data: Record<string, number>): SeriesDataUnit[] {
return Object.entries(data).map(([bucket, count]) => ({
value: count,
name: new Date(bucket).getTime(),
}));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that could be moved to static/app/views/teamInsights/utils.tsx and reused in static/app/views/teamInsights/teamAlertsTriggered.tsx?

Copy link
Member Author

@scttcper scttcper Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah probably, might need a better name

@scttcper scttcper changed the title feat(workflow): Add team issues and team feat(workflow): Add team issues and time to resolution Oct 6, 2021
@scttcper scttcper enabled auto-merge (squash) October 6, 2021 22:32
@scttcper scttcper merged commit 0d3f101 into master Oct 6, 2021
@scttcper scttcper deleted the scttcper/team-activity branch October 6, 2021 22:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants