Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Add empty dependency array to useLegacyStore #29086

Merged
merged 1 commit into from
Oct 6, 2021
Merged

fix(ui): Add empty dependency array to useLegacyStore #29086

merged 1 commit into from
Oct 6, 2021

Conversation

davidenwang
Copy link
Contributor

Adds empty dependency array to prevent continual calls to listen and unlisten

@davidenwang davidenwang requested review from scttcper and a team October 5, 2021 20:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

size-limit report

Path Base Size (669cccc) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.66 KB 52.66 KB -0.02% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

@davidenwang davidenwang enabled auto-merge (squash) October 6, 2021 00:31
@davidenwang davidenwang merged commit a8929cb into master Oct 6, 2021
@davidenwang davidenwang deleted the davidenwang/fix-legacy-store branch October 6, 2021 00:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

@scttcper scttcper Awaiting requested review from scttcper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidenwang @evanpurkhiser