fix(ui): Revert change to disabled button tooltips #29085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylangocmen
approved these changes
Oct 5, 2021
evanpurkhiser
approved these changes
Oct 6, 2021
|
@priscilawebdev what was the change for specifically? |
|
the problem was that when the button was disabled in the dynamic sampling modal, no tooltip was being shown. The change solved the issue
|
|
Please where is this problem happening? it seems to work fine for me. if we merge this change the tooltip will no longer be displayed on the disabled button
|
|
@priscilawebdev here's where i saw it Kapture.2021-10-06.at.09.59.17.mp4 |
Quickly mousing over a disabled button with a tooltip would cause the tooltip to persist forever
a99d772 to
9f9772b
Compare
|
@priscilawebdev maybe we can enable overriding the skipWrapper for that use case or use a tooltip to wrap that button directly |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickly mousing over a disabled button with a tooltip would cause the tooltip to persist forever