feat(suspect-spans): Change ingestion to project scope flag #29076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To limit the scope of the rollout, change the suspect spans ingestion to a project scope flag to allow us to roll it out by the project.
dashed
approved these changes
Oct 5, 2021
dashed
reviewed
Oct 5, 2021
src/sentry/options/defaults.py
Outdated
| @@ -374,3 +374,5 @@ | |||
| # This is to allow gradual rollout of metrics collection for symbolication requests and can be | |||
| # removed once it is fully rolled out. | |||
| register("symbolicate-event.low-priority.metrics.submission-rate", default=0.0) | |||
|
|
|||
| register("performance:suspect-spans-ingestion-projects", default={}) | |||
There was a problem hiding this comment.
Would registering this in getsentry be better?
There was a problem hiding this comment.
Doesn't look like we have any conventions for this, but I think you're right that it might fit better in getsentry. Though for this PR, I'm going to keep it here as this is not permanent and will be removed when we can take the feature flag off.
wmak
approved these changes
Oct 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To limit the scope of the rollout, change the suspect spans ingestion to a
project scope flag to allow us to roll it out by the project.