chore(performance): Drop legacy key transactions table #29074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to #29015 to drop the table as it is no longer in use.
|
This PR has a migration; here is the generated SQL BEGIN;
--
-- Delete model KeyTransaction
--
DROP TABLE "sentry_discoverkeytransaction" CASCADE;
COMMIT; |
markstory
reviewed
Oct 6, 2021
|
|
||
| operations = [ | ||
| migrations.DeleteModel( | ||
| name="KeyTransaction", |
There was a problem hiding this comment.
Do you know if this table is attached to any ETL jobs?
There was a problem hiding this comment.
I'm not aware of any ETL jobs using this table, is there any way to confirm this is the case?
There was a problem hiding this comment.
You could search the getsentry/etl repo for any hits.
There was a problem hiding this comment.
No, I'm not seeing any usages of this table in getsentry or etl. Also did a quick search across the org and not getting any hits.
markstory
approved these changes
Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #29015 to drop the table as it is no longer in use.