Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discover): discover add to dashboard button uses y axis from query #29046

Merged

Conversation

edwardgou-sentry
Copy link
Contributor

Add to Dashboard now defaults the widget Y-Axis to the selected Y-Axis on the Discover Results Chart.
When switching the widget to the Table visualization, the widget will use columns from the Discover table as the Y-Axis instead

image
image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021

size-limit report

Path Base Size (bf6292e) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.66 KB 52.66 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwardgou-sentry edwardgou-sentry merged commit 49b672c into master Oct 5, 2021
@edwardgou-sentry edwardgou-sentry deleted the feat/discover-add-to-dashboard-default-yaxis branch October 5, 2021 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants