ref(debug-files): Buffer updates to reprocessing revision project option #29041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beezz
commented
Oct 4, 2021
| ProjectOption, | ||
| columns={}, | ||
| filters={"project": project, "key": REPROCESSING_OPTION}, | ||
| signal_only=True, |
There was a problem hiding this comment.
signal_only=True so the actual update happens in receiver and will properly reload cache via the ProjectOption.objects.set_value.
There was a problem hiding this comment.
I absolutely love how you have to specify a model cls that, with signal_only, is only used as input for the redis key and nothing else.
untitaker
approved these changes
Oct 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.