Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: Erroneous apply_async call (#29032)" #29038

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Revert "fix: Erroneous apply_async call (#29032)" #29038

merged 1 commit into from
Oct 4, 2021

Conversation

tonyo
Copy link
Contributor

@tonyo tonyo commented Oct 4, 2021

Reverts #29032

@tonyo tonyo requested a review from a team October 4, 2021 13:56
@tonyo tonyo enabled auto-merge (squash) October 4, 2021 14:27
@billyvg billyvg disabled auto-merge October 4, 2021 14:30
@billyvg billyvg changed the title Revert "fix: Erroneous apply_async call" Revert "fix: Erroneous apply_async call (#29032)" Oct 4, 2021
@billyvg
Copy link
Member

billyvg commented Oct 4, 2021

Merging this revert, artifact uploading is failing intermittently and blocking the merge, but tests are passing

@billyvg billyvg merged commit 6655a0b into master Oct 4, 2021
@billyvg billyvg deleted the revert-29032-fix/apply-async branch October 4, 2021 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oioki oioki oioki approved these changes

@relaxolotl relaxolotl relaxolotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyo @billyvg @oioki @relaxolotl