feat(cmp_alerts): Support comparisonDelta parameter in OrganizationEventsStatsEndpoint
#29028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies `timeseries_query` to accept a `comparison_delta`, which is used to make an additional timeshifted query that we compare to the original. This produces % changes deltas for each bucket. So if we had a query between 2021-09-20 15:30 - 2021-09-20 18:30 with an hourly rollup, and a `comparison_delta` of 1 day, then we'd make a second query between `2021-09-19 15:30 - 2021-09-19 18:30`. The queries produce: - 0, 10, 500, 100 - 10, 0, 400, 200 Comparison results are - 0, 0 (comparison value is 0 so we can't divide), 25 (25% increase), -50 (50% decrease) I'll hook this up to the api in a separate pr.
…nEventsStatsEndpoint` This adds the `comparisonDelta` parameter to `OrganizationEventsStatsEndpoint`. This value is in seconds, and is used to determine the comparison period we use when generating comparison stats. If the comparisonDelta caused the comparison period to go outside of the orgs retention window then we'll return an error.
87f253d to
edf28a6
Compare
ahmedetefy
approved these changes
Oct 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
comparisonDeltaparameter toOrganizationEventsStatsEndpoint. This value is inseconds, and is used to determine the comparison period we use when generating comparison stats.
If the comparisonDelta caused the comparison period to go outside of the orgs retention window then
we'll return an error.