Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): Group team alerts triggered by week (WOR-1407) #29026

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Oct 1, 2021

Groups alerts triggered by week
image

@scttcper scttcper requested a review from a team October 1, 2021 22:49
@scttcper scttcper changed the title feat(workflow): Group team alerts triggered by week feat(workflow): Group team alerts triggered by week (WOR-1407) Oct 1, 2021
@@ -72,31 +72,38 @@ class TeamIssues extends AsyncComponent<Props, State> {

renderBody() {
const {alertsTriggered} = this.state;
const data = Object.entries(alertsTriggered ?? {})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of data identifier is not clear, can we elaborate on the identifier e.g alertData

Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the alertsTriggered response. Are we guaranteed to have an entry for every single day? So that when we chunk it by 7 we for sure get rolling weeks?

@scttcper
Copy link
Member Author

scttcper commented Oct 4, 2021

Are we guaranteed to have an entry for every single day?

Yep its zero filled

@scttcper scttcper merged commit 3d23521 into master Oct 4, 2021
@scttcper scttcper deleted the scttcper/weekly-triggered branch October 4, 2021 16:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants