Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discover): multi y axis support for discover landing page query previews #29016

Merged
merged 5 commits into from
Oct 5, 2021

Conversation

edwardgou-sentry
Copy link
Contributor

updated MiniGraph to accept yAxis prop to support previewing multi yaxis on saved queries
image

@edwardgou-sentry edwardgou-sentry requested review from a team October 1, 2021 16:23
@edwardgou-sentry
Copy link
Contributor Author

Removed the aggregateMultiPlotType switch from getChartType since we don't have a scenario where we would use line charts for Discover at the moment (for multi series and single series).

Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about a feature check but otherwise LGTM

organization={organization}
referrer={referrer}
/>
features={['connect-discover-and-dashboards', 'dashboards-edit']}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity why does this feature check need dashboards-edit too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right dashboards-edit isn't needed here 😄 . Updated!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

size-limit report

Path Base Size (d2ec4b0) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.66 KB 52.66 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

@edwardgou-sentry edwardgou-sentry merged commit f9dc253 into master Oct 5, 2021
@edwardgou-sentry edwardgou-sentry deleted the feat/discover-multi-y-axis-query-list branch October 5, 2021 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants