-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(discover): multi y axis support for discover landing page query previews #29016
feat(discover): multi y axis support for discover landing page query previews #29016
Conversation
axis saved queries
Removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about a feature check but otherwise LGTM
organization={organization} | ||
referrer={referrer} | ||
/> | ||
features={['connect-discover-and-dashboards', 'dashboards-edit']} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity why does this feature check need dashboards-edit too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right dashboards-edit
isn't needed here 😄 . Updated!
…er-multi-y-axis-query-list
size-limit report
|
updated

MiniGraph
to acceptyAxis
prop to support previewing multi yaxis on saved queries