Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): Sort group tags alphabetically #29005

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Conversation

scttcper
Copy link
Member

When the page is loaded the backend sends them in -count order which can seem almost random. This sorts them by tag name.

  • sort tags alphabetically
  • switch to RTL from enzyme
  • use AsyncComponent instead of custom component
  • removes some inline styles

image

@scttcper scttcper requested a review from a team September 30, 2021 22:43
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (493559e) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.51 KB 52.51 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left two minor suggestions

Comment on lines 68 to 73
<GlobalSelectionLink
className="btn btn-default btn-sm"
to={`${baseUrl}tags/${tag.key}/`}
>
{t('More Details')}
</GlobalSelectionLink>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I used something like this previously:

<Button
    to={{
      pathname: `/organizations/${orgSlug}/something`,
      query: extractSelectionParameters(location.query),
    }}
 >

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@scttcper scttcper merged commit 5f96412 into master Oct 1, 2021
@scttcper scttcper deleted the scttcper/sort-tags branch October 1, 2021 20:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants