-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflow): Sort group tags alphabetically #29005
Conversation
size-limit report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left two minor suggestions
<GlobalSelectionLink | ||
className="btn btn-default btn-sm" | ||
to={`${baseUrl}tags/${tag.key}/`} | ||
> | ||
{t('More Details')} | ||
</GlobalSelectionLink> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I used something like this previously:
<Button
to={{
pathname: `/organizations/${orgSlug}/something`,
query: extractSelectionParameters(location.query),
}}
>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!!
When the page is loaded the backend sends them in
-count
order which can seem almost random. This sorts them by tag name.