fix(deletions) Improve AlertRule deletions #28999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the previous fix solved for active alert rules I didn't notice that the default object manager for AlertRules excludes snapshot status records. These records are causing deletions to fail now as they hold references to Environment via SnubaQuery. When Django cascades deletes for Environment records it ends up in the post_delete signal and fails. Fixes SENTRY-SAB
wedamija
approved these changes
Sep 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the previous fix solved for active alert rules I didn't notice that the default object manager for AlertRules excludes snapshot status records. These records are causing deletions to fail now as they hold references to Environment via SnubaQuery. When Django cascades deletes for Environment records it ends up in the post_delete signal and fails.
Fixes SENTRY-SAB