Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Install docs line height #28998

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

vuluongj20
Copy link
Member

Some elements in install docs (namely <alert />) don't have explicit line heights but instead inherit a value of 1 from StyledSettingsWrapper.

Screen Shot 2021-09-30 at 10 41 10 AM

This commit fixes that by setting an inheritable line height on DocumentationWrapper:

Screen Shot 2021-09-30 at 10 41 31 AM

Some elements in install docs (namely `<alert />`) don't have explicit line heights but instead inherit a value of 1 from `StyledSettingsWrapper`.
@vuluongj20 vuluongj20 enabled auto-merge (squash) October 11, 2021 18:26
@vuluongj20 vuluongj20 merged commit 41bd8ea into master Oct 11, 2021
@vuluongj20 vuluongj20 deleted the vuluong/config-docs-line-height branch October 11, 2021 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants