Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ui): Prepare alert metricsChart for sessions #28992

Merged
merged 1 commit into from
Oct 4, 2021
Merged

ref(ui): Prepare alert metricsChart for sessions #28992

merged 1 commit into from
Oct 4, 2021

Conversation

matejminar
Copy link
Member

Diff looks kind of messy, but this PR is not changing a thing. Just moving logic from render method to renderChart method, so that we don't need to duplicate it once we add sessions request in a follow-up PR.

@matejminar matejminar requested a review from a team September 30, 2021 14:46
@matejminar matejminar merged commit 621d0cc into master Oct 4, 2021
@matejminar matejminar deleted the ref/metric-chart-sessions branch October 4, 2021 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejminar @scttcper