Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ui) Update more deprecated forms including ones in manage #28991

Merged
merged 2 commits into from
Oct 4, 2021
Merged

ref(ui) Update more deprecated forms including ones in manage #28991

merged 2 commits into from
Oct 4, 2021

Conversation

markstory
Copy link
Member

@markstory markstory commented Sep 30, 2021 •
edited by chadwhitacre
Loading

  • Update the testSessionPercent view to not use a deprecated form input.
  • Update self-hosted manage settings page to new-style settings forms that save on blur. Saving on blur lets us save individual fields and works around not being able to submit the entire form due to disabled fields.

New Manage settings

Screen Shot 2021-09-30 at 9 38 32 AM

@markstory markstory requested review from scttcper and a team September 30, 2021 13:39
BYK
BYK reviewed Sep 30, 2021
View reviewed changes
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints here. Just skimmed over the code, nothing jumps at me.

@markstory markstory requested review from a team and removed request for scttcper October 4, 2021 13:34
@markstory markstory merged commit e0a0b6a into master Oct 4, 2021
@markstory markstory deleted the fix-forminput branch October 4, 2021 19:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BYK BYK BYK left review comments

@billyvg billyvg billyvg approved these changes

@chadwhitacre chadwhitacre chadwhitacre approved these changes

@matejminar matejminar matejminar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@markstory @billyvg @BYK @chadwhitacre @matejminar