Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(js): Avoid rebuilding routes w/ memoization #28975

Merged
merged 1 commit into from
Sep 30, 2021
Merged

perf(js): Avoid rebuilding routes w/ memoization #28975

merged 1 commit into from
Sep 30, 2021

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team September 30, 2021 00:30
matejminar
matejminar approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, our route tree is fairly large - I wonder if there'll be any measurable difference.

@evanpurkhiser
Copy link
Member Author

Looks like building routes takes ~5ms, so it's not super significant, but I think it's good.

@evanpurkhiser evanpurkhiser merged commit ffbd41f into master Sep 30, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/perf-js-avoid-rebuilding-routes-w-memoization branch September 30, 2021 09:26
vuluongj20 pushed a commit that referenced this pull request Sep 30, 2021
@evanpurkhiser @vuluongj20
perf(js): Avoid rebuilding routes w/ memoization (#28975)
89376c1
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matejminar matejminar matejminar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @matejminar