Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ui): Convert checkbox fancy to RTL #28959

Merged
merged 1 commit into from
Sep 29, 2021
Merged

test(ui): Convert checkbox fancy to RTL #28959

merged 1 commit into from
Sep 29, 2021

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Sep 29, 2021 •
edited
Loading

adds the "mixed" aria-checked state when the checkbox is indeterminate
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/checkbox_role

@scttcper scttcper requested a review from a team September 29, 2021 19:56
@scttcper scttcper requested a review from a team as a code owner September 29, 2021 19:56
markstory
markstory approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@markstory markstory left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will be nice to try and replace this with an actual checkbox input and use accent-color to make it sentry purple.

@scttcper scttcper merged commit 99d2059 into master Sep 29, 2021
@scttcper scttcper deleted the scttcper/RTL-checkboxfancy branch September 29, 2021 21:08
vuluongj20 pushed a commit that referenced this pull request Sep 30, 2021
@scttcper @vuluongj20
test(ui): Convert checkbox fancy to RTL (#28959)
72777af
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markstory markstory markstory approved these changes

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scttcper @markstory @evanpurkhiser