feat(team-store): Support user teams state in TeamStore #28957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidenwang
commented
Sep 29, 2021
| }, | ||
|
|
||
| loadInitialData(items, hasMore = null) { | ||
| this.initialized = true; | ||
| this.state = { | ||
| teams: items.sort((a, b) => a.slug.localeCompare(b.slug)), | ||
| // TODO(davidenwang): Replace with a more reliable way of knowing when we have loaded all teams | ||
| loadedUserTeams: items.length < MAX_TEAMS, |
There was a problem hiding this comment.
loadInitialData is called on app startup (from loadTeamsAndProjects) and will fetch up to 100 teams. If we receive less than 100 teams it means that we have not hit that 100 team pagination limit and therefore have all the organization's teams which means we have the user's teams in there somewhere as well.
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
Augment the team store with state relating to whether or not the user's teams are loaded. This will be useful to avoid continually refetching the user's teams.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment the team store with state relating to whether or not the user's teams are loaded. This will be useful to avoid continually refetching the user's teams.