Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discover): Add a default for count_unique #28952

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

shruthilayaj
Copy link
Member

Adding a default for count_unique so that
it doesn't error when user tries to save
the columns without a parameter (since
the param is a required field)

Adding a default for count_unique so that
it doesn't error when user tries to save
the columns without a parameter (since
the param is a required field)
@shruthilayaj shruthilayaj marked this pull request as ready for review September 29, 2021 20:41
@shruthilayaj shruthilayaj requested a review from a team September 29, 2021 20:41
@shruthilayaj shruthilayaj requested a review from a team as a code owner September 29, 2021 20:41
Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could we do something similar for the other less popular functions too (eg. min/max)

@shruthilayaj shruthilayaj merged commit 36ab1b0 into master Oct 4, 2021
@shruthilayaj shruthilayaj deleted the fix/make-count-unique-param-required branch October 4, 2021 20:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants