-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(discover): enable multi y axis for previous period view #28951
feat(discover): enable multi y axis for previous period view #28951
Conversation
3d1962a
to
6e0a0f3
Compare
size-limit report
|
Is this a false alarm? |
I think baseChart is in the main bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…er-multi-y-axis-previous-period
@wmak 👍 nice catch, fixed! |
…er-multi-y-axis-previous-period
…er-multi-y-axis-previous-period
…er-multi-y-axis-previous-period
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds multi y axis support for

Previous Period
display view in Discover results chart:When using multiple y axis series, previous period series will be plotted as stacked dotted lines using colours based off the original series. Single y axis previous period display is unchanged (will still use grey when plotting previous period series).
currentSeriesName
andpreviousSeriesName
props inEventsRequest
were pluralized and changed fromstring
type tostring[]
to support multiple previous series. Some dependants ofEventsRequest
were updated to reflect this but without any functional changes.