-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release-comparison): Add performance section on release details #28948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add frontend, backend, mobile, and unknown performance section placeholders. Follow-up PRs will include performance data and any other design updates. FIXES WOR-1389
matejminar
reviewed
Sep 30, 2021
matejminar
reviewed
Oct 4, 2021
matejminar
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me.
Before releasing this to a wider audience, we should improve this view on mobile - can you please ask @robinrendle for some design guidance there?
merging this and will do design updates in a follow-up PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up #27796 into smaller/more manageable PRs
Add frontend, backend, mobile, and unknown performance section placeholders. Follow-up PRs will include performance data and any other design updates.
FIXES WOR-1389
Before
After
Frontend Section
Backend Section
Mobile Section
Unknown Section