Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release-comparison): Add performance section on release details #28948

Merged
merged 5 commits into from
Oct 5, 2021

Conversation

mikellykels
Copy link
Contributor

Breaking up #27796 into smaller/more manageable PRs

Add frontend, backend, mobile, and unknown performance section placeholders. Follow-up PRs will include performance data and any other design updates.

FIXES WOR-1389

Before

127266795-3ef3aceb-f20b-4b51-9c13-a843205fbc91

After

Frontend Section

Screen Shot 2021-09-29 at 7 37 46 AM

Backend Section

Screen Shot 2021-09-29 at 7 38 11 AM

Mobile Section

Screen Shot 2021-09-29 at 7 38 30 AM

Unknown Section

Screen Shot 2021-09-29 at 7 38 46 AM

Add frontend, backend, mobile, and unknown performance section placeholders. Follow-up PRs will include performance data and any other design updates.

FIXES WOR-1389
@mikellykels mikellykels requested a review from a team as a code owner September 29, 2021 15:15
@mikellykels mikellykels requested review from a team and removed request for a team September 29, 2021 15:15
Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

Before releasing this to a wider audience, we should improve this view on mobile - can you please ask @robinrendle for some design guidance there?

@mikellykels mikellykels merged commit f5d0000 into master Oct 5, 2021
@mikellykels mikellykels deleted the kelly/performance-section-placeholders branch October 5, 2021 20:10
@mikellykels
Copy link
Contributor Author

merging this and will do design updates in a follow-up PR

@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants