fix(semver): Set semver cols on pre_save #28946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
approved these changes
Sep 29, 2021
tests/sentry/models/test_release.py
Outdated
| @@ -847,6 +847,41 @@ def test_parse_release_into_semver_cols_with_get_or_create(self): | |||
| assert release.build_number is None | |||
| assert release.package == "org.example.FooApp" | |||
|
|
|||
| def test_parse_release_into_semver_cols_on_pre_save(self): | |||
| """ | |||
| Test that ensures get_or_create populates semver fields | |||
There was a problem hiding this comment.
Nit: These doc strings look wrong
There was a problem hiding this comment.
oops you are right.. I had it on my mind to change but forgot
Creates a pre_save signal that parses release version into semver on creation
59e0fdd to
d2efe5c
Compare
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
Creates a pre_save signal that parses release version into semver on creation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a pre_save signal that parses release version into semver on creation