feat(discover): Allow more options for the topEvents #28926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This allows up to 10 top events on the discover frontend - This changes the display *text* to `Top Daily` and `Top Display` and adds a new dropdown for the limit
wmak
commented
Sep 29, 2021
| @@ -45,6 +50,10 @@ export default function ChartFooter({ | |||
| <SectionValue key="total-value">{total.toLocaleString()}</SectionValue> | |||
| ) | |||
| ); | |||
| const topEventOptions: SelectValue<string>[] = []; | |||
| for (let i = 2; i <= 10; i++) { | |||
There was a problem hiding this comment.
Not sure if there's an argument for allowing top-1?
There was a problem hiding this comment.
I think people could conceivably want to look at "top event"? I don't have strong opinions on this other than it looks less odd if we just allow 1-10.
There was a problem hiding this comment.
👍 Good point, i'll update this to include 1 just so its more aesthetically pleasing
shruthilayaj
approved these changes
Sep 29, 2021
| @@ -45,6 +50,10 @@ export default function ChartFooter({ | |||
| <SectionValue key="total-value">{total.toLocaleString()}</SectionValue> | |||
| ) | |||
| ); | |||
| const topEventOptions: SelectValue<string>[] = []; | |||
| for (let i = 2; i <= 10; i++) { | |||
There was a problem hiding this comment.
I think people could conceivably want to look at "top event"? I don't have strong opinions on this other than it looks less odd if we just allow 1-10.
|
Oh and should we add tests? |
- Shrinking the width of dropdown - Including 1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top DailyandTop Displayandadds a new dropdown for the limit
Preview