perf(ui): Prevent unnecessary endpoint requests #28924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeandher
approved these changes
Sep 30, 2021
| @@ -39,6 +39,7 @@ type Props = { | |||
| projectId: string; | |||
| orgId: string; | |||
| children: ((props: ChildFuncProps) => React.ReactNode) | React.ReactNode; | |||
| loadingProjects: boolean; | |||
There was a problem hiding this comment.
Can we make this boolean more explanatory (shouldLoadProjects, isLoadingProjects, etc.)
There was a problem hiding this comment.
Nevermind turns out this is a built-in thing with the Projects HOC, my bad
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
Identify and remove duplicate API queries by our frontend client for our slowest pages. One endpoint that gets called multiple times unnecessarily is
/api/0/projects/{organization_slug}/{project_slug}/. P95 for this query is 334.00ms. This is the low hanging fruit for page speed optimization.https://sentry.io/organizations/sentry/performance/summary/?project=1&query=transaction.duration%3A%3C15m+transaction%3A%2Fapi%2F0%2Fprojects%2F%7Borganization_slug%7D%2F%7Bproject_slug%7D%2F+event.type%3Atransaction+http.method%3AGET&showTransactions=slow&statsPeriod=24h&transaction=%2Fapi%2F0%2Fprojects%2F%7Borganization_slug%7D%2F%7Bproject_slug%7D%2F&unselectedSeries=p100%28%29