fix(integrations): Integration ID TypeError #28916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scefali
reviewed
Sep 28, 2021
| @@ -37,15 +37,20 @@ def clean(self): | |||
| cleaned_data = super().clean() | |||
|
|
|||
| integration_id = cleaned_data.get("account") | |||
| try: | |||
| integration_id = int(integration_id) | |||
There was a problem hiding this comment.
Shouldn’t this be a validation error?
There was a problem hiding this comment.
EDIT: I guess this is optional but we should still give a validation error if the param is given and it’s not an int
scefali
approved these changes
Sep 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app was crashing while trying to turn an optional parameter into an
int.Fixes SENTRY-SA9.