feat(integrations): Make sync_status_inbound a Task
#28906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32f9299 to
f0ac860
Compare
leeandher
approved these changes
Oct 1, 2021
src/sentry/integrations/issues.py
Outdated
Comment on lines
332
to
334
| def should_sync(self, attribute: str) -> bool: | ||
| key = getattr(self, f"{attribute}_key", None) | ||
| return self.org_integration.config.get(key, False) |
There was a problem hiding this comment.
this is a clever and satisfying refactor 👏
|
|
||
| def get_done_states(self, project: str) -> Sequence[str]: | ||
| def _get_done_statuses(self, project: str) -> Set[str]: |
There was a problem hiding this comment.
should this be _get_done_states?
There was a problem hiding this comment.
I wanted to match _get_done_statuses() from src/sentry/integrations/jira/.
| @retry(exclude=(Integration.DoesNotExist,)) | ||
| @track_group_async_operation | ||
| def sync_status_inbound( | ||
| integration_id: int, organization_id: int, issue_key: str, data: Mapping[str, Any] |
There was a problem hiding this comment.
I agree that providing a formless blob of data isn't ideal here, but since the task doesn't directly handle or 'expect a shape' from the data, I think it should be fine.
816d052 to
f6dd510
Compare
added 2 commits
October 1, 2021 16:32
8bb6b28 to
6be88ff
Compare
6be88ff to
7301830
Compare
7301830 to
44e9560
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure Devops webhooks requests are timing out waiting for statuses to sync. This PR makes syncing async.
Something to note I have to pass an arbitrary JSON blob to the task but I'm not sure if that's kosher.