Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboards): skip renderTag when data.value is undefined #28899

Merged
merged 2 commits into from
Sep 28, 2021
Merged

fix(dashboards): skip renderTag when data.value is undefined #28899

merged 2 commits into from
Sep 28, 2021

Conversation

edwardgou-sentry
Copy link
Contributor

Calling this.renderTag(data.value.kind) when data.value is undefined will throw an error.
This fix checks for truthy values on data.value before rendering field tags.

@edwardgou-sentry edwardgou-sentry requested review from a team September 28, 2021 14:18
@edwardgou-sentry edwardgou-sentry merged commit e1989cc into master Sep 28, 2021
@edwardgou-sentry edwardgou-sentry deleted the fix/widget-undefined-field-tags branch September 28, 2021 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dashed dashed dashed approved these changes

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardgou-sentry @dashed @Zylphrex