Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interface-breadcrumb): Add breadcrumb eventlink #28889

Merged
merged 2 commits into from
Sep 29, 2021
Merged

feat(interface-breadcrumb): Add breadcrumb eventlink #28889

merged 2 commits into from
Sep 29, 2021

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Sep 28, 2021 •
edited by Jesse-Box
Loading

  • created useSessionStorage hook
  • created eventLink component
  • update code to pass route and router down

Preview:

image

image

ps: Currently, the UI needs to send two requests to get all the necessary data, but we will create a new endpoint in the next Sprint and replace those two requests with just one.

@priscilawebdev priscilawebdev force-pushed the ref/add-breadcrumb-eventlink branch from 9029b2f to 0cb9a4e Compare September 28, 2021 07:55
@priscilawebdev priscilawebdev force-pushed the ref/add-breadcrumb-eventlink branch from 0cb9a4e to d28143e Compare September 28, 2021 07:58
@priscilawebdev priscilawebdev changed the title Ref/add breadcrumb eventlink feat(interface-breadcrumb): Add breadcrumb eventlink Sep 28, 2021
@priscilawebdev priscilawebdev force-pushed the ref/add-breadcrumb-eventlink branch from d28143e to c3c8fb2 Compare September 28, 2021 12:52
@priscilawebdev priscilawebdev marked this pull request as ready for review September 28, 2021 12:58
@priscilawebdev priscilawebdev requested a review from a team as a code owner September 28, 2021 12:58
@priscilawebdev priscilawebdev requested a review from a team September 28, 2021 12:58
@priscilawebdev priscilawebdev requested a review from a team as a code owner September 28, 2021 12:58
@priscilawebdev priscilawebdev requested review from a team and removed request for a team September 28, 2021 12:59
untitaker
untitaker reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I think this will not find events outside of the currently viewed groups? ignore me dum dum

@Jesse-Box
Copy link
Contributor

🚢 it

markstory
markstory reviewed Sep 28, 2021
View reviewed changes
static/app/utils/useSessionStorage.tsx
}, [state]);

function removeItem() {
sessionStorage.removeItem(key);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this blank out the state as well? Right now you could removeItem() and still have state present.

@priscilawebdev priscilawebdev enabled auto-merge (squash) September 29, 2021 08:12
@priscilawebdev priscilawebdev merged commit e67ff3e into master Sep 29, 2021
@priscilawebdev priscilawebdev deleted the ref/add-breadcrumb-eventlink branch September 29, 2021 08:14
vuluongj20 pushed a commit that referenced this pull request Sep 30, 2021
@priscilawebdev @vuluongj20
feat(interface-breadcrumb): Add breadcrumb eventlink (#28889)
b0783d8
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@untitaker untitaker untitaker left review comments

@markstory markstory markstory approved these changes

@dashed dashed dashed approved these changes

@Jesse-Box Jesse-Box Jesse-Box approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@priscilawebdev @Jesse-Box @markstory @dashed @untitaker