Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Force refresh projects/teams on project creation #28886

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Sep 28, 2021

fixes an issue after project creation where the new project isn't available in the store.

Adds a retry button to the project details page that should attempt to reload projects

image

@scttcper scttcper changed the title fix(ui): Force refresh projects/teams on project creation fix(ui): Force refresh projects/teams on project creation (ISSUE-1275) Sep 28, 2021
@scttcper scttcper requested review from matejminar and a team September 28, 2021 20:08
@scttcper scttcper marked this pull request as ready for review September 28, 2021 20:08
@@ -202,7 +202,7 @@ class OrganizationContextContainer extends React.Component<Props, State> {
this.props.api,
OrganizationContextContainer.getOrganizationSlug(this.props),
true,
true
false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you validate that the new user onboarding experience still works OK?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested it! seems to be working as expected

@scttcper scttcper changed the title fix(ui): Force refresh projects/teams on project creation (ISSUE-1275) fix(ui): Force refresh projects/teams on project creation Sep 29, 2021
@scttcper scttcper merged commit 5bb8200 into master Sep 29, 2021
@scttcper scttcper deleted the scttcper/force-refresh-org-and-projects-on-create branch September 29, 2021 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants