fix(discover): only disable y axis checkbox if at maximum selected #28877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
approved these changes
Sep 27, 2021
|
Code looks good to me |
Thanks Evan! |
dashed
approved these changes
Sep 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if the user had 3 yAxis selected, we would disable the entire row and checkboxes for all other yAxis options.
Since we've added the feature to exclusively select yAxis options by clicking on an option row, we no longer need to disable the row, only the checkbox needs to be disabled
This change updates the option disabling to only affect the checkbox and moves the tooltip to the checkbox element