Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): LayoutTitle semantic heading #28876

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Conversation

robinrendle
Copy link
Contributor

@robinrendle robinrendle commented Sep 27, 2021

Layout.Title was previously a <h2> but it should be a <h1>. No visual changes here since Layout.Title overrides the default styles of our <h1>

@robinrendle robinrendle requested a review from a team as a code owner September 27, 2021 22:02
@robinrendle robinrendle changed the title fix(ui): LayoutTitle is now a h1 fix(ui): LayoutTitle semantic heading Sep 27, 2021
Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any visual changes from this?

@robinrendle
Copy link
Contributor Author

@evanpurkhiser There shouldn’t be, no. Just a html change. Going to wait for the snapshots though and see.

@robinrendle robinrendle merged commit d5c3b18 into master Sep 27, 2021
@robinrendle robinrendle deleted the rr/fixed-h1-in-layout branch September 27, 2021 23:04
vuluongj20 pushed a commit that referenced this pull request Sep 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants