Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(routes): Organize frontend routes.tsx #28875

Merged
merged 1 commit into from
Sep 28, 2021
Merged

style(routes): Organize frontend routes.tsx #28875

merged 1 commit into from
Sep 28, 2021

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Sep 27, 2021 •
edited
Loading

For the most part route ordering has not changed

I did however, clean up a few trees in some minor ways.

The biggest change is that the create project, new project, and getting started routes have all moved into a /organizations/:orgId/projects/ tree

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/style-routes-organize-frontend-routes-tsx branch from 41ef467 to b814619 Compare September 27, 2021 23:19
@evanpurkhiser evanpurkhiser requested review from a team September 27, 2021 23:19
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/style-routes-organize-frontend-routes-tsx branch from b814619 to 2b81fb0 Compare September 27, 2021 23:26
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/style-routes-organize-frontend-routes-tsx branch from 2b81fb0 to e96e65e Compare September 27, 2021 23:27
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/style-routes-organize-frontend-routes-tsx branch from e96e65e to e1fb84a Compare September 27, 2021 23:30
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/style-routes-organize-frontend-routes-tsx branch from e1fb84a to 5447fb1 Compare September 27, 2021 23:32
matejminar
matejminar approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried locally, looks good to me.

@evanpurkhiser evanpurkhiser merged commit 074e2b2 into master Sep 28, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/style-routes-organize-frontend-routes-tsx branch September 28, 2021 18:21
vuluongj20 pushed a commit that referenced this pull request Sep 30, 2021
@evanpurkhiser @vuluongj20
style(routes): Organize frontend routes.tsx (#28875)
ac26e1b
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matejminar matejminar matejminar approved these changes

@davidenwang davidenwang davidenwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanpurkhiser @matejminar @davidenwang