ref(sdk): Testing default idleTimeout #28868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default idleTimeout for our sdk is 1000ms, many months back we increased the number from the default to increase our collection of LCP, but we don't have any hard numbers on the impact. This will help us test our LCP collection, although it could have some impact on trends.
dashed
approved these changes
Sep 27, 2021
AbhiPrasad
approved these changes
Sep 27, 2021
k-fish
added a commit
that referenced
this pull request
Sep 29, 2021
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
The default idleTimeout for our sdk is 1000ms, many months back we increased the number from the default to increase our collection of LCP, but we don't have any hard numbers on the impact. This will help us test our LCP collection, although it could have some impact on trends.
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default idleTimeout for our sdk is 1000ms, many months back we increased the number from the default to increase our collection of LCP, but we don't have any hard numbers on the impact. This will help us test our LCP collection temporarily, to see if we need to increase our default idleTimeouts.
Other:
There could be some temporary impact on trends when changing this.