feat(growth): Alert Bar on issue page for sample events #28864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashed
reviewed
Sep 28, 2021
static/app/components/alertBar.tsx
Outdated
| font-size: 14px; | ||
| `; | ||
|
|
||
| export default AlertBar; |
There was a problem hiding this comment.
This sounds pretty generic. Should this have a story in storybook?
There was a problem hiding this comment.
@Neo-Zhixing Agreed with Evan, maybe we can make a more specific name?
There was a problem hiding this comment.
Any recommendations? (naming is hard)
ActionableAlertBar? PageAlertBar?
Btw this is now added to the storybook.
Co-authored-by: Alberto Leal <mail4alberto@gmail.com>
scefali
reviewed
Oct 4, 2021
scefali
reviewed
Oct 4, 2021
|
@Neo-Zhixing can you include a screenshot? |
scefali
reviewed
Oct 4, 2021
scefali
reviewed
Oct 4, 2021
scefali
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
@Neo-Zhixing looks good to me, I would let support know about this change in case there are any questions related to it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user is looking at a sample error, show a banner that takes the user to the "Getting Started" page in the app.