Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discover): allow up to 10 top events #28862

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

wmak
Copy link
Member

@wmak wmak commented Sep 27, 2021

  • This updates the top events endpoint so it allows up to 10 top events instead of the current limit of 5
  • Also updated the test so its more dynamic instead of a hardcoded 50

- This updates the top events endpoint so it allows up to 10 top events
  instead of the current limit of 5
- Also updated the test so its more dynamic instead of a hardcoded 50
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmak wmak enabled auto-merge (squash) September 28, 2021 19:38
@wmak wmak merged commit e9185a5 into master Sep 28, 2021
@wmak wmak deleted the wmak/feat/enable-larger-top-events branch September 28, 2021 19:38
vuluongj20 pushed a commit that referenced this pull request Sep 30, 2021
- This updates the top events endpoint so it allows up to 10 top events
  instead of the current limit of 5
- Also updated the test so its more dynamic instead of a hardcoded 50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants