Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(routes): Remove SettingsProjectProvider #28842

Merged
merged 1 commit into from
Sep 27, 2021
Merged

ref(routes): Remove SettingsProjectProvider #28842

merged 1 commit into from
Sep 27, 2021

Conversation

evanpurkhiser
Copy link
Member

We can just inject project in the parent component

@evanpurkhiser evanpurkhiser requested review from a team September 24, 2021 22:55
matejminar
matejminar approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good to me.

priscilawebdev
priscilawebdev approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evanpurkhiser evanpurkhiser merged commit 4cd1835 into master Sep 27, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-routes-remove-settingsprojectprovider branch September 27, 2021 19:26
vuluongj20 pushed a commit that referenced this pull request Sep 30, 2021
@evanpurkhiser @vuluongj20
ref(routes): Remove SettingsProjectProvider (#28842)
37d8823
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matejminar matejminar matejminar approved these changes

@priscilawebdev priscilawebdev priscilawebdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanpurkhiser @matejminar @priscilawebdev