ref(ui) Convert Saved Issue Search to new forms #28839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update saved issue search to settings/forms. I've also replaced the custom footer buttons with more standard size ones.
| /> | ||
| <SelectField | ||
| key="sort" | ||
| name="sort" | ||
| label={t('Sort By')} | ||
| value={query} |
There was a problem hiding this comment.
do we need to pass the value here? doesn't the form do it for us?
markstory
commented
Sep 27, 2021
Co-authored-by: Matej Minar <matej.minar@sentry.io> Co-authored-by: Priscila Oliveira <priscilawebdev@gmail.com>
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
Update saved issue search to settings/forms. I've also replaced the custom footer buttons with more standard size ones. Co-authored-by: Matej Minar <matej.minar@sentry.io> Co-authored-by: Priscila Oliveira <priscilawebdev@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update saved issue search to settings/forms. I've also replaced the custom footer buttons with more standard size ones, and replaced the alert with a component instead of LESS styles.
Before
After