test(alert-rules): Add a barebones spec test for the RuleNode component #28834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeandher
commented
Sep 24, 2021
Comment on lines
-69
to
-71
| initialVal = fieldConfig.initial; | ||
| } else { | ||
| initialVal = fieldConfig.choices[0][0]; |
There was a problem hiding this comment.
Even though the field when changed will provide strings (as per #28828), I believe this original intention behind this code was to always have a value in the field even on first load with no default set.
This coerces every possible value into a string so that those fields will start of populated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #28828
This PR adds a barebones spec test to the Rule Node component. It ensures that the Text, Number and Choice fields work correctly, with special consideration for the
number->stringweirdness in the linked PR above. It also includes a lot of TODOs as those are a bit out of my scope, but would be great additions by someone with more context into those rules.There are a few TODOs I've assigned myself that will be addressed as part of a new rule I'm building (See: #28659)