ref(discover): Introduce some order to discover columns #28832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This sorts fields, tags, measurements and breakdowns alphabetically
- This regroups functions slightly so that they're next to other similar
functions (eg. avg + percentile)
- Not sorting alphabetically cause the order of some things become
strange (eg. p100 before p50)
wmak
commented
Sep 24, 2021
| isSortable: true, | ||
| multiPlotType: 'area', | ||
| }, | ||
| eps: { |
There was a problem hiding this comment.
sorta count related, so i've put this with the other count functions
wmak
commented
Sep 24, 2021
| @@ -507,6 +508,7 @@ export function generateFieldOptions({ | |||
| } | |||
|
|
|||
| if (measurementKeys !== undefined && measurementKeys !== null) { | |||
| measurementKeys.sort(); | |||
There was a problem hiding this comment.
could sort these at the source, but this way we can add more and they'll be sorted without any additional dev work. List is small enough I can't imagine this will have a perf impact
dashed
approved these changes
Sep 24, 2021
shruthilayaj
approved these changes
Sep 24, 2021
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
- This sorts fields, tags, measurements and breakdowns alphabetically
- This regroups functions slightly so that they're next to other similar
functions (eg. avg + percentile)
- Not sorting alphabetically cause the order of some things become
strange (eg. p100 before p50)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions (eg. avg + percentile)
strange (eg. p100 before p50)