fix(alert-rules): Use the data default value for time selectors in SelectControl #28815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iProgramStuff
approved these changes
Sep 24, 2021
scttcper
approved these changes
Sep 24, 2021
82f277c to
7cfb4d3
Compare
|
Looks like @leeandher reverted the changes in #28828 this isn't necessary anymore |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've changed the selector value assignment in #28804
This restores back using the
data[name]in time selectors, since the have values such as:'1m', '1y', '30d', '2w'they get parsed to int and name-value pairs are not usable in time/period/interval selectors.Before (prod):
Screen.Recording.2021-09-23.at.7.10.09.PM.mov
After:
Screen.Recording.2021-09-23.at.7.11.34.PM.mov